Repository navigation
fix cs check in CI - #829
Merged
Merged
Conversation
There was a problem hiding this comment.
Pull Request Overview
This pull request updates the CI configuration so that PHP-CS-Fixer only checks coding style without modifying source files, and also updates PHPUnit to its latest version.
- Configure PHP-CS-Fixer with dry-run mode to display diffs without applying fixes.
- Upgrade PHPUnit to the latest version.
Files not reviewed (1)
- composer.json: Language not supported
Comments suppressed due to low confidence (1)
.github/workflows/build.yaml:29
- Ensure that using '--diff --dry-run' causes PHP-CS-Fixer to exit with a non-zero code when coding style issues are found, so that the CI build fails appropriately.
args: --diff --dry-run
Collaborator
Author
|
The failure visible in https://github.com/KnpLabs/KnpPaginatorBundle/actions/runs/14462535518/job/40557680604?pr=829 shows exactly what I mean. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Our current build of php-cs-fixer in CI fixes the source code instead of checking it: if a file has a wrong coding style, it is changed. That's useless, since the file is only changed in the build instance, and mainly it doesn't exit with a failing code.
I also added the latest version of PHPUnit