Skip to content

Changes default Red Hat (rhel) logo to current logo "The hat" - #148

Merged
HorlogeSkynet merged 1 commit into
HorlogeSkynet:masterfrom
helmchen:feature/new_RedHat_Logo
Feb 19, 2024
Merged

HorlogeSkynet merged 1 commit into
HorlogeSkynet:masterfrom
helmchen:feature/new_RedHat_Logo

Conversation

@helmchen

Copy link
Copy Markdown
Contributor

The default logo for RHEL has been changed to the new logo "the hat". The previous logo is sill available as alternate logo shadowman

Description

  • Implementation of the the new logo
  • renaming the previous logo to LOGO_SHADOWMAN
  • Providing alias for the current logo as LOGO_HAT

Reason and / or context

Cosmetic reasoons :-)

How has this been tested ?

Visually tested using following commands:

python3 -m archey -d rhel
python3 -m archey -d rhel -l shadow man

on a Mac (macOS 13.6.3 x86_64; Darwin 22.6.0) from macOS terminal as well as from inside VSCode.

Types of changes :

  • Bug fix (non-breaking change which fixes an issue)
  • Typo / style fix (non-breaking change which improves readability)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist :

  • [IF NEEDED] I have updated the README.md file accordingly ;
  • [IF NEEDED] I have updated the test cases (which pass) accordingly ;
  • [IF BREAKING] This pull request targets next Archey version branch ;
  • My changes looks good ;
  • I agree that my code may be modified in the future ;
  • My code follows the code style of this project (PEP8).

@HorlogeSkynet
HorlogeSkynet self-requested a review February 17, 2024 08:49
@HorlogeSkynet HorlogeSkynet added the enhancement ⬆️ Implements a new feature, fixes or improves existing ones label Feb 17, 2024
@HorlogeSkynet HorlogeSkynet added this to the v4.14.3.0 milestone Feb 17, 2024
@HorlogeSkynet
HorlogeSkynet force-pushed the feature/new_RedHat_Logo branch from a3fc490 to f537008 Compare February 17, 2024 09:23
@HorlogeSkynet

HorlogeSkynet commented Feb 17, 2024 •

Copy link
Copy Markdown
Owner

Hey @helmchen, awewome PR ! Many thanks.

I've rebased your branch and fixed a remaining tabulation.
Moreover, "empty logo lines" are disallowed (but the corresponding test case is broken for alternative logos) so I've removed the first one you initially added.

Tell me whether you're OK with the proposed changes 🙂

@HorlogeSkynet
HorlogeSkynet force-pushed the feature/new_RedHat_Logo branch from f537008 to df42cfb Compare February 17, 2024 16:43
@HorlogeSkynet

Copy link
Copy Markdown
Owner

(test case has been fixed on master [see 8817077], I've rebased again your branch 🙏)

@helmchen

Copy link
Copy Markdown
Contributor Author

Hey @helmchen, awewome PR ! Many thanks.

I've rebased your branch and fixed a remaining tabulation. Moreover, "empty logo lines" are disallowed (but the corresponding test case is broken for alternative logos) so I've removed the first one you initially added.

Tell me whether you're OK with the proposed changes 🙂

Hi @HorlogeSkynet

Your are welcome 😀.

Your changes are ok for me. Sorry for the tabs which broke linting, I'll check them better before the next PR.

@HorlogeSkynet
HorlogeSkynet merged commit df61178 into HorlogeSkynet:master Feb 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement ⬆️ Implements a new feature, fixes or improves existing ones

Development

Successfully merging this pull request may close these issues.

2 participants