Skip to content

[Output] Adds configuration option for preferred logo style - #124

Merged
HorlogeSkynet merged 1 commit into
masterfrom
feature/logo-style-config
Nov 15, 2022
Merged

HorlogeSkynet merged 1 commit into
masterfrom
feature/logo-style-config

Conversation

@ingrinder

@ingrinder ingrinder commented Nov 15, 2022 •

Copy link
Copy Markdown
Collaborator

Adds a configuration option for the preferred logo style

Description

A few simple changes to Output to allow this.

Reason and / or context

Feature addition by request (#99) 😃

How has this been tested ?

Setting distribution to Darwin and specifying the option seems to work for me. Also worked when I added a placeholder extra logo for my own distro and specified it as a style.

Types of changes :

  • Bug fix (non-breaking change which fixes an issue)
  • Typo / style fix (non-breaking change which improves readability)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist :

  • [IF NEEDED] I have updated the README.md file accordingly ;
  • [IF NEEDED] I have updated the test cases (which pass) accordingly ;
  • [IF BREAKING] This pull request targets next Archey version branch ;
  • My changes looks good ;
  • I agree that my code may be modified in the future ;
  • My code follows the code style of this project (PEP8).

@HorlogeSkynet HorlogeSkynet left a comment •

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome and clean patch @ingrinder ! Thanks, merging this.

@HorlogeSkynet
HorlogeSkynet merged commit e1169a4 into master Nov 15, 2022
@HorlogeSkynet
HorlogeSkynet deleted the feature/logo-style-config branch November 15, 2022 19:00
@parkerbxyz

Copy link
Copy Markdown

Wow, that was quick! 😄 Thank you so much! ✨

parkerbxyz added a commit to parkerbxyz/dotfiles that referenced this pull request Nov 15, 2022
Support for this option was added in HorlogeSkynet/archey4#124
parkerbxyz added a commit to parkerbxyz/dotfiles that referenced this pull request Nov 19, 2022
Support for the logo style option was added in HorlogeSkynet/archey4#124
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: DONE

Development

Successfully merging this pull request may close these issues.

3 participants