Repository navigation
fix: set status on acquistion - #4843
Conversation
| status: | ||
| conditions: | ||
| - lastTransitionTime: "1970-01-01T00:00:00Z" | ||
| message: The resource is up to date | ||
| reason: UpToDate | ||
| status: "True" | ||
| type: Ready |
There was a problem hiding this comment.
compare this with object 01, notice the lack of additional fields
|
I think the CI is broken at HEAD! |
Signed-off-by: Alex Pana <8968914+acpana@users.noreply.github.com>
Signed-off-by: Alex Pana <8968914+acpana@users.noreply.github.com>
5026b03 to
7aa6a6d
Compare
| settings: | ||
| tier: db-f1-micro | ||
| --- | ||
| TEST: ABANDON |
There was a problem hiding this comment.
Why don't we use ABANDON-AND-REACQUIRE directly?
There was a problem hiding this comment.
the test needs a resourceID and I didn't want to introduce that to this yaml.
| return err | ||
| } | ||
|
|
||
| instanceForStatus := a.actual |
There was a problem hiding this comment.
nit: maybe use updated := a.actual so that we don't need this additional variable instanceForStatus.
for example:
updated := a.actual
if xxx {
...
updated, err = a.sqlInstancesClient.Get(a.projectID, a.resourceID).Context(ctx).Do()
...
}
status, err := SQLInstanceStatusGCPToKRM(updated)
|
/lgtm |
yuwenma
left a comment
yuwenma
left a comment
There was a problem hiding this comment.
/approve
One nit. Non blocker.
| annotations: | ||
| cnrm.cloud.google.com/deletion-policy: abandon |
There was a problem hiding this comment.
nit: ABANDON sets the "deletion-policy: abandon" already.
k8s-config-connector/tests/e2e/script_test.go
Line 296 in 378f305
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: yuwenma The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
3 participants
Change description
Fixes #4811
Special notes for your reviewer:
Does this PR add something which needs to be 'release noted'?
Additional documentation e.g., references, usage docs, etc.:
Intended Milestone
Please indicate the intended milestone.