Skip to content

Loosen Terraform version constraints in modules and add version warning - #5750

Merged
parulbajaj01 merged 2 commits into
GoogleCloudPlatform:developfrom
parulbajaj01:parul/terraform
Jun 10, 2026
Merged

parulbajaj01 merged 2 commits into
GoogleCloudPlatform:developfrom
parulbajaj01:parul/terraform

Conversation

@parulbajaj01

Copy link
Copy Markdown
Contributor

This PR loosens the strict Terraform version constraint (= 1.12.2) across all modules in the repository to required_version = ">= 1.12.2". It also updates the cluster-toolkit's dependency resolver to perform pre-flight version checks, warning users when they use non-standard versions rather than blocking execution.

Submission Checklist

NOTE: Community submissions can take up to 2 weeks to be reviewed.

Please take the following actions before submitting this pull request.

  • Fork your PR branch from the Toolkit "develop" branch (not main)
  • Test all changes with pre-commit in a local branch #
  • Confirm that "make tests" passes all tests
  • Add or modify unit tests to cover code changes
  • Ensure that unit test coverage remains above 80%
  • Update all applicable documentation
  • Follow Cluster Toolkit Contribution guidelines #

@parulbajaj01
parulbajaj01 requested a review from a team as a code owner June 8, 2026 10:28
@parulbajaj01 parulbajaj01 added the release-breaking-changes Prevents "smooth" re-deploy across versions label Jun 8, 2026
@gemini-code-assist

Copy link
Copy Markdown
Contributor

Summary of Changes

Hello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request improves the flexibility of the repository's infrastructure by loosening strict Terraform version constraints. By moving to a minimum version requirement, users can utilize newer versions of Terraform while maintaining compatibility. Additionally, the dependency resolver has been updated to include non-blocking warnings for non-standard versions, which improves the overall developer experience by providing helpful feedback without halting operations.

Highlights

  • Terraform Version Flexibility: Updated the Terraform required_version constraint from a strict '= 1.12.2' to '>= 1.12.2' across all modules in the repository.
  • Dependency Resolver Enhancements: Introduced a pre-flight version check in the dependency resolver that warns users about non-standard Terraform versions instead of blocking execution.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini or @gemini-code-assist . Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize the Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counterproductive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the required Terraform version constraint from = 1.12.2 to >= 1.12.2 across all modules, READMEs, and templates. It also updates the dependency resolver in Go to check the locally installed Terraform version, allowing newer versions while warning the user, and failing only on older, incompatible versions. A critical compilation issue was identified in pkg/dependencies/resolver.go where the strings package is used but not imported.

Comment thread pkg/dependencies/resolver.go
Comment thread pkg/dependencies/resolver.go Outdated
Comment thread pkg/dependencies/resolver.go Outdated
Comment thread pkg/dependencies/resolver.go Outdated
Comment thread pkg/dependencies/resolver.go Outdated

@shubpal07 shubpal07 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @parulbajaj01 for putting this PR!

Left some non-blocking technical suggestions below to simplify the control flow and make the version parsing more resilient to varied versioning formats.

Please feel free to defer some suggestions in the next iterations.

@parulbajaj01
parulbajaj01 requested a review from shubpal07 June 10, 2026 07:22

@shubpal07 shubpal07 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fast revision @parulbajaj01 !!
LGTM

@parulbajaj01
parulbajaj01 merged commit 6d9946a into GoogleCloudPlatform:develop Jun 10, 2026
15 of 84 checks passed
ksaishree pushed a commit to ksaishree/cluster-toolkit that referenced this pull request Jun 18, 2026
Neelabh94 pushed a commit to Neelabh94/cluster-toolkit that referenced this pull request Jun 18, 2026
ep-nag pushed a commit to nagconsulting/cluster-toolkit that referenced this pull request Aug 7, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

release-breaking-changes Prevents "smooth" re-deploy across versions

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants