Repository navigation
Loosen Terraform version constraints in modules and add version warning - #5750
Conversation
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request improves the flexibility of the repository's infrastructure by loosening strict Terraform version constraints. By moving to a minimum version requirement, users can utilize newer versions of Terraform while maintaining compatibility. Additionally, the dependency resolver has been updated to include non-blocking warnings for non-standard versions, which improves the overall developer experience by providing helpful feedback without halting operations. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize the Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counterproductive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request updates the required Terraform version constraint from = 1.12.2 to >= 1.12.2 across all modules, READMEs, and templates. It also updates the dependency resolver in Go to check the locally installed Terraform version, allowing newer versions while warning the user, and failing only on older, incompatible versions. A critical compilation issue was identified in pkg/dependencies/resolver.go where the strings package is used but not imported.
shubpal07
left a comment
There was a problem hiding this comment.
Thanks @parulbajaj01 for putting this PR!
Left some non-blocking technical suggestions below to simplify the control flow and make the version parsing more resilient to varied versioning formats.
Please feel free to defer some suggestions in the next iterations.
shubpal07
left a comment
There was a problem hiding this comment.
Thanks for the fast revision @parulbajaj01 !!
LGTM
6d9946a
into
GoogleCloudPlatform:develop
This PR loosens the strict Terraform version constraint (= 1.12.2) across all modules in the repository to required_version = ">= 1.12.2". It also updates the cluster-toolkit's dependency resolver to perform pre-flight version checks, warning users when they use non-standard versions rather than blocking execution.
Submission Checklist
NOTE: Community submissions can take up to 2 weeks to be reviewed.
Please take the following actions before submitting this pull request.