Repository navigation
Validate Sidecar forwarded header configuration - #4018
Merged
Iarek Kovtunenko (iarekk) merged 4 commits intoSep 14, 2026
Merged
Iarek Kovtunenko (iarekk) merged 4 commits into
Iarek Kovtunenko (iarekk) merged 4 commits into
Conversation
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Contributor
There was a problem hiding this comment.
Pull request overview
Adds a Sidecar startup guard against automatic forwarded-header processing outside Development.
Changes:
- Validates
ForwardedHeaders_Enabledduring builder creation. - Adds focused environment and configuration tests.
- Exposes the internal builder factory to the signed test assembly.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
src/Microsoft.Identity.Web.Sidecar/Program.cs |
Adds startup validation. |
src/Microsoft.Identity.Web.Sidecar/Properties/InternalsVisibleTo.cs |
Grants test access to internals. |
tests/E2E Tests/Sidecar.Tests/ForwardedHeadersConfigurationTests.cs |
Covers accepted and rejected configurations. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Nilesh Choudhary (4gust)
approved these changes
Sep 2, 2026
Contributor
Author
|
Copilot resolve the merge conflicts in this pull request |
…rwarded-header-validation-minimal # Conflicts: # src/Microsoft.Identity.Web.Sidecar/Properties/InternalsVisibleTo.cs Co-authored-by: iNinja <538318+iNinja@users.noreply.github.com>
Contributor
Resolved the merge conflict with current master in commit |
Bogdan Gavril (bgavrilMS)
approved these changes
Sep 14, 2026
Iarek Kovtunenko (iarekk)
enabled auto-merge (squash)
September 14, 2026 17:41
Iarek Kovtunenko (iarekk)
deleted the
iinglese/sidecar-forwarded-header-validation-minimal
branch
September 14, 2026 17:43
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Release notes
Sidecar startup now rejects automatic forwarded-header processing outside
Development when
ForwardedHeaders_Enabledis set totrue.Testing