Repository navigation
feat: do not hard block VM sizes that are not known - #1796
Merged
Matthew Christopher (matthchr) merged 6 commits intoJul 17, 2026
Merged
Conversation
Instead, deprioritize them by setting price to 999 -- user can override with NodeOverlays. This unblocks using preview SKUs that are not yet in known SKUs while still avoiding the outage risk that a new cheap SKU shows up that doesn't work and everybody gets by default.
Maximiliano Uribe Falcon (MaximilianoUribe)
previously approved these changes
Jul 16, 2026
Alex Leites (tallaxes)
previously approved these changes
Jul 16, 2026
Matthew Christopher (matthchr)
dismissed stale reviews from Alex Leites (tallaxes) and Maximiliano Uribe Falcon (MaximilianoUribe)
via
July 16, 2026 23:31
3627f9f
Maximiliano Uribe Falcon (MaximilianoUribe)
approved these changes
Jul 16, 2026
Alex Leites (tallaxes)
approved these changes
Jul 17, 2026
Matthew Christopher (matthchr)
deleted the
matthchr/deprioritize-unknown-skus
branch
July 17, 2026 05:20
lnguyen924
pushed a commit
that referenced
this pull request
Jul 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Instead, deprioritize them by setting price to 999 -- user can override with NodeOverlays.
This unblocks using preview SKUs that are not yet in known SKUs while still avoiding the outage risk that a new cheap SKU shows up that doesn't work and everybody gets by default.
How was this change tested?
Does this change impact docs?
Release Note