Repository navigation
feat: additional configurations for Kafka Trigger and Output - #306
Merged
Merged
Conversation
Pranava (aloiva)
commented
Nov 14, 2025
Pranava (aloiva)
commented
Contributor
- Adds configurations for kafka trigger and output.
- Taken from KafkaTriggerAttribute, KafkaAttribute
Pranava (aloiva)
requested review from
Gavin Aguiar (gavin-aguiar),
hallvictoria and
Varad Meru (vrdmr)
as code owners
November 14, 2025 14:51
Pranava (aloiva)
changed the title
Contributor
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Contributor
Author
|
hallvictoria thanks for pointing them out! can you queue azp again so i can check out what's failing and fix it? |
Contributor
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Contributor
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Contributor
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Contributor
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Contributor
Author
|
hallvictoria we should be good to merge this, no? |
Contributor
|
Hey Pranava (@aloiva), could you please also add pydocs for the new |
Contributor
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Contributor
Author
|
hallvictoria , didn't notice there was a failing UT. fixed it now 😃 |
Contributor
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
hallvictoria
approved these changes
Feb 9, 2026
hallvictoria
left a comment
hallvictoria
left a comment
Contributor
There was a problem hiding this comment.
lgtm, thanks for this!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.