Skip to content

Login: skip erroneous tenant - #2634

Merged
Yugang Wang (yugangw-msft) merged 2 commits into
Azure:masterfrom
yugangw-msft:skiptenant
Mar 27, 2017
Merged

Yugang Wang (yugangw-msft) merged 2 commits into
Azure:masterfrom
yugangw-msft:skiptenant

Conversation

@yugangw-msft

Copy link
Copy Markdown
Contributor

Fix #2591.
The context is users might have tenant where his account is disabled by admin, failing the whole login flow is not the optimal experience as this blocks them from using subscription in legit tenants.

@derekbekoe Derek Bekoe (derekbekoe) left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov-io

Codecov (codecov-io) commented Mar 27, 2017 •

Copy link
Copy Markdown

Codecov Report

Merging #2634 into master will increase coverage by 0.42%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2634      +/-   ##
==========================================
+ Coverage   71.81%   72.23%   +0.42%     
==========================================
  Files         376      396      +20     
  Lines       20708    21397     +689     
  Branches     3038     3103      +65     
==========================================
+ Hits        14871    15457     +586     
- Misses       4903     4978      +75     
- Partials      934      962      +28
Impacted Files Coverage Δ
src/azure-cli-core/azure/cli/core/_profile.py 84.36% <100%> (+0.17%) ⬆️
...ure-cli-sql/azure/cli/command_modules/sql/_util.py 90% <0%> (ø) ⬆️
...-cli-sql/azure/cli/command_modules/sql/commands.py 100% <0%> (ø) ⬆️
...-cli-dls/azure/cli/command_modules/dls/__init__.py 100% <0%> (ø)
...re-cli-dla/azure/cli/command_modules/dla/custom.py 50.47% <0%> (ø)
...zure-cli-dls/azure/cli/command_modules/__init__.py 100% <0%> (ø)
...rc/command_modules/azure-cli-dls/azure/__init__.py 100% <0%> (ø)
...i-dls/azure/cli/command_modules/dls/_validators.py 31.57% <0%> (ø)
...-cli-dls/azure/cli/command_modules/dls/commands.py 100% <0%> (ø)
...-cli-dla/azure/cli/command_modules/dla/__init__.py 100% <0%> (ø)
... and 17 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update afee409...f7c206b. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants