Skip to content

Wayland: Properly report desktop scaling as 1 - #22245

Merged
MrJul merged 1 commit into
mainfrom
fixes/wayland-misreported-desktop-scaling
Sep 17, 2026
Merged

MrJul merged 1 commit into
mainfrom
fixes/wayland-misreported-desktop-scaling

Conversation

@kekekeks

Copy link
Copy Markdown
Member

We are reporting logical size for displays and are using identity for PointTo/FromScreen, so user code might get confused.

We are reporting logical size for displays and are using identity for PointTo/FromScreen, so user code might get confused.
@kekekeks kekekeks added enhancement backport-candidate-12.1.x Consider this PR for backporting to 12.1 branch labels Sep 16, 2026
@kekekeks
kekekeks requested a balanced review from Copilot September 16, 2026 20:42

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

The change consistently aligns desktop scaling with existing Wayland screen and coordinate behavior.

Pull request overview

Aligns Wayland desktop scaling with its logical coordinate system.

Changes:

  • Reports DesktopScaling as 1, consistent with logical display sizes and identity coordinate conversion.
File summaries
File Description
src/Avalonia.Wayland/WindowImplBase.cs Uses identity desktop scaling for Wayland windows.
Review details
  • Files reviewed: 1/1 changed files
  • Comments generated: 0
  • Review effort level: Balanced

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

@avaloniaui-bot

Copy link
Copy Markdown

You can test this PR using the following package version. 12.2.999-cibuild0070022-alpha. (feed url: https://nuget-feed-all.avaloniaui.net/v3/index.json) [PRBUILDID]

@MrJul
MrJul added this pull request to the merge queue Sep 17, 2026
Merged via the queue into main with commit dd81603 Sep 17, 2026
12 checks passed
@MrJul
MrJul deleted the fixes/wayland-misreported-desktop-scaling branch September 17, 2026 08:29
kekekeks added a commit that referenced this pull request Sep 21, 2026
We are reporting logical size for displays and are using identity for PointTo/FromScreen, so user code might get confused.
@kekekeks kekekeks added backported-12.1.x and removed backport-candidate-12.1.x Consider this PR for backporting to 12.1 branch labels Sep 21, 2026
grokys pushed a commit to Evan260/Avalonia that referenced this pull request Oct 7, 2026
We are reporting logical size for displays and are using identity for PointTo/FromScreen, so user code might get confused.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants