Repository navigation
Fix SplineEasing constructor overwriting Y1 instead of setting Y2 - #22169
Merged
Merged
Conversation
MrJul
added
backport-candidate-12.1.x
|
You can test this PR using the following package version. |
MrJul
pushed a commit
to MrJul/Avalonia
that referenced
this pull request
Sep 22, 2026
MrJul
added
backported-12.1.x
and removed
backport-candidate-12.1.x
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does the pull request do?
The four-parameter SplineEasing constructor copied y2 into Y1, leaving Y2 at the KeySpline default (1). XAML property setters and the KeySpline overload were unaffected.
What is the current behavior?
new SplineEasing(x1, y1, x2, y2) writes y2 into Y1. Y2 stays at the KeySpline default of 1.
What is the updated/expected behavior with this PR?
All four control points are assigned. Covered by SplineEasing_Constructor_Assigns_All_Control_Points.
How was the solution implemented (if it's not obvious)?
Checklist
Breaking changes
Obsoletions / Deprecations
Fixed issues