Repository navigation
fix: light dismiss behavior fails when opened from the ContextMenu. - #22037
Conversation
|
You can test this PR using the following package version. |
|
MrJul
added
bug
backport-candidate-12.1.x
|
@cla-avalonia agree |
There was a problem hiding this comment.
Pull request overview
Fixes light-dismiss state when overlapping popups close out of opening order.
Changes:
- Tracks active light-dismiss registrations.
- Preserves overlay visibility and pass-through state for remaining popups.
- Adds regression coverage for sequential popup closure.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
src/Avalonia.Controls/Primitives/LightDismissOverlayLayer.cs |
Adds registration-based overlay state management. |
src/Avalonia.Controls/Primitives/Popup.cs |
Registers each light-dismiss popup with the overlay. |
tests/Avalonia.Controls.UnitTests/Primitives/PopupTests.cs |
Tests closing an earlier popup without affecting the next. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
2. Eliminate misinformation that Registration may bring. 3. Remove LightDismissOverlayLayer Manually set IsVisible to false at creation time.
|
You can test this PR using the following package version. |
|
You can test this PR using the following package version. |
…valoniaUI#22037) * fix: light dismiss behavior fails when opened from the ContextMenu. * 1. LightDismissOverlayLayer is invisible by default. 2. Eliminate misinformation that Registration may bring. 3. Remove LightDismissOverlayLayer Manually set IsVisible to false at creation time. --------- Co-authored-by: Steven Kirk
MrJul
added
backported-12.1.x
and removed
backport-candidate-12.1.x
What does the pull request do?
Fixed an issue where the light dismiss behavior failed to work when a popup was opened from a context menu.
What is the current behavior?
Light dismiss failed when a popup was opened from a context menu.
What is the updated/expected behavior with this PR?
Light dismiss works when a popup is opened from a context menu.
Checklist
Fixed issues
Fixes #22036