Skip to content

Align ExpandCollapseState member order with UIA - #21693

Merged
MrJul merged 1 commit into
masterfrom
fix/expand-collapse-uia-order
Jul 2, 2026
Merged

MrJul merged 1 commit into
masterfrom
fix/expand-collapse-uia-order

Conversation

@jmacato

@jmacato jmacato commented Jul 2, 2026

Copy link
Copy Markdown
Member

What does the pull request do?

Reorders the ExpandCollapseState enum members so their values match UIA's ExpandCollapseState (Collapsed=0, Expanded=1, PartiallyExpanded=2, LeafNode=3). The enum documents itself as representing the UIA property, and the Win32 automation layer passes its value through to UIA_ExpandCollapseExpandCollapseStatePropertyId unconverted, so the member order is the wire format.

@jmacato jmacato added area-accessibility backport-candidate-12.0.x Consider this PR for backporting to 12.0 branch labels Jul 2, 2026
@MrJul

MrJul commented Jul 2, 2026

Copy link
Copy Markdown
Member

This is a breaking change; consider mapping values in the UIA layer instead.

@avaloniaui-bot

Copy link
Copy Markdown

You can test this PR using the following package version. 12.1.999-cibuild0067079-alpha. (feed url: https://nuget-feed-all.avaloniaui.net/v3/index.json) [PRBUILDID]

@jmacato

jmacato commented Jul 2, 2026

Copy link
Copy Markdown
Member Author

This is a breaking change; consider mapping values in the UIA layer instead.

good catch! will change

…tion layer; Avalonia declares PartiallyExpanded and LeafNode in the opposite order from UIA.
@jmacato
jmacato force-pushed the fix/expand-collapse-uia-order branch from 595492f to 7e0a11a Compare July 2, 2026 17:31
@avaloniaui-bot

Copy link
Copy Markdown

You can test this PR using the following package version. 12.1.999-cibuild0067087-alpha. (feed url: https://nuget-feed-all.avaloniaui.net/v3/index.json) [PRBUILDID]

@MrJul MrJul left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@MrJul
MrJul added this pull request to the merge queue Jul 2, 2026
@github-merge-queue
github-merge-queue Bot removed this pull request from the merge queue due to failed status checks Jul 2, 2026
@MrJul
MrJul added this pull request to the merge queue Jul 2, 2026
Merged via the queue into master with commit facc253 Jul 2, 2026
11 checks passed
@MrJul
MrJul deleted the fix/expand-collapse-uia-order branch July 2, 2026 20:10
@MrJul MrJul removed the backport-candidate-12.0.x Consider this PR for backporting to 12.0 branch label Jul 9, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants