Repository navigation
AT-SPI: Expose list item containers as accessible children - #21605
Merged
Merged
Conversation
Index selectable items directly under the selection container so the Selection interface's SelectChild/DeselectChild address them by index.
|
You can test this PR using the following package version. |
MrJul
added
os-linux
area-accessibility
backport-candidate-12.0.x
MrJul
reviewed
Jun 17, 2026
jmacato
marked this pull request as draft
June 17, 2026 11:55
ListBox used ItemsControlAutomationPeer, which is not an ISelectionProvider, so it never exposed the Selection interface (AT-SPI) for multi-select.
|
You can test this PR using the following package version. |
Move the GetChildrenCore container override down to ItemsControlAutomationPeer so every ItemsControl returns its containers, and return null directly when there are no items instead of calling the base algorithm.
jmacato
marked this pull request as ready for review
June 17, 2026 15:46
|
You can test this PR using the following package version. |
|
You can test this PR using the following package version. |
… the AT-SPI selection handler
|
You can test this PR using the following package version. |
|
You can test this PR using the following package version. |
…not the shared peer Present a SelectingItemsControl's realized item containers as its direct AT-SPI children inside AtSpiNode so SelectChild-by-index and a selectable item's parent lookup resolve to the Selection container. Doing this in the FreeDesktop AT-SPI layer keeps the macOS AX and Windows UIA peer trees intact, avoiding the item-frame and tree-collapse regressions the shared ItemsControlAutomationPeer override caused.
|
You can test this PR using the following package version. |
MrJul
changed the title
MrJul
changed the title
MrJul
added this pull request to the merge queue
Jun 22, 2026
MrJul
pushed a commit
to MrJul/Avalonia
that referenced
this pull request
Jun 23, 2026
…I#21605) * AT-SPI: add to the selection in Selection.SelectChild instead of replacing it * AT-SPI: expose list item containers as accessible children Index selectable items directly under the selection container so the Selection interface's SelectChild/DeselectChild address them by index. * Expose ListBox selection to accessibility via a selection peer ListBox used ItemsControlAutomationPeer, which is not an ISelectionProvider, so it never exposed the Selection interface (AT-SPI) for multi-select. * Address review: expose item containers from the base ItemsControl peer Move the GetChildrenCore container override down to ItemsControlAutomationPeer so every ItemsControl returns its containers, and return null directly when there are no items instead of calling the base algorithm. * Use file-scoped namespace in ListBoxAutomationPeer * Fix cross-platform regression: move child flattening from the peer to the AT-SPI selection handler * Trigger rebuild * AT-SPI: flatten selection container item children in the node layer, not the shared peer Present a SelectingItemsControl's realized item containers as its direct AT-SPI children inside AtSpiNode so SelectChild-by-index and a selectable item's parent lookup resolve to the Selection container. Doing this in the FreeDesktop AT-SPI layer keeps the macOS AX and Windows UIA peer trees intact, avoiding the item-frame and tree-collapse regressions the shared ItemsControlAutomationPeer override caused.
MrJul
added
backported-12.0.x
and removed
backport-candidate-12.0.x
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
List automation peers exposed the items panel/scrollviewer as their accessible children, so the items were not direct children of the selection container. AT-SPI addresses selectable children by index on the container (SelectChild/DeselectChild), so item selection over AT-SPI could not reach the items.
Expose the realized item containers as the accessible children of SelectingItemsControl peers (ListBox, TreeView, ComboBox), matching how the selection model already resolves items via ContainerFromIndex.
Builds on #21602 (additive SelectChild). The first commit here is that change; it will drop out once #21602 merges.