Updated Correspondence models

[danielskovli]

Addresses the remaining gaps from altinn-studio#17405 — the Correspondence Notification V2 integration made non-breaking changes to the request/response contract, and our client needed to catch up.

Status of the three change areas in #17405

Area	State
Initialize request — customNotificationRecipients → customRecipients + overrideRegisteredContactInformation	✅ Already handled by earlier work (now on main)
Initialize response — per-correspondence notifications may be null	✅ Already nullable, deserializes cleanly
Correspondence details — notificationStatusDetails plural lists + nullable id	🛠️ Fixed here

Changes

All on the correspondence details/status (GetStatus) response path:

1. CorrespondenceNotificationStatusDetailsResponse.Id: Guid → Guid?
   V2 can return "id": null for a notification channel status. The non-nullable Guid caused System.Text.Json to throw when deserializing the details response, so any GetStatus call against a V2 notification with a null id failed.

2. Added Emails / Smses to CorrespondenceNotificationSummaryResponse
   The API now exposes notificationStatusDetails.emails / .smses as lists (for notifications sent to multiple recipients), alongside the legacy singular email / sms. These were previously dropped on deserialization.

3. Deprecated the singular Email / Sms
   In the API's V2→V1 mapper these are a back-compat projection (the latest recipient) of the plural lists. Marked [Obsolete] pointing at Emails / Smses; the properties are retained (still deserialized), so this is not a breaking change.

Additional drift found & fixed

A sanity check of the full client⇄API contract surfaced two response status enums missing values the API can return. Since these enums deserialize by string name and JsonStringEnumConverter throws on an unknown name, each was a latent crash:

4. CorrespondenceStatus — added AttachmentsDownloaded (server value 12). Set once a recipient downloads attachments; it appears in the issue's own example payload and broke GetStatus for any such correspondence (including via statusHistory).

5. CorrespondenceAttachmentStatusResponse — added Expired (server value 5).

All changes are additive / widening — no binary-compatibility impact. The public-API snapshot has been regenerated accordingly.

Related

• Stacks on Fix signing notification for signees with multiple identifiers #1812
• Closes Altinn/altinn-studio#17405
• Closes Altinn/altinn-studio#17410

Tests

• Status_NotificationV2Response_DeserializesNullIdAndPluralRecipientLists — null id + populated emails/smses.
• Status_AttachmentsDownloadedStatus_DeserializesCorrectly — AttachmentsDownloaded as both top-level and statusHistory status.

🤖 Generated with Claude Code

[coderabbitai]

📝 Walkthrough

Walkthrough

Three correspondence response models are updated: CorrespondenceStatus adds AttachmentsDownloaded, CorrespondenceAttachmentStatusResponse adds Expired, CorrespondenceNotificationStatusDetailsResponse.Id becomes Guid?, and CorrespondenceNotificationSummaryResponse adds plural Emails/Smses list properties while marking Email/Sms obsolete. Two regression tests and a public API snapshot are updated accordingly.

Changes

Correspondence Model Contract Updates

Layer / File(s)	Summary
Enum additions, nullable Id, and plural notification list properties src/.../CorrespondenceStatus.cs, src/.../Response/CorrespondenceAttachmentStatusResponse.cs, src/.../Response/CorrespondenceNotificationStatusDetailsResponse.cs, src/.../Response/CorrespondenceNotificationSummaryResponse.cs	CorrespondenceStatus gains AttachmentsDownloaded = 12; CorrespondenceAttachmentStatusResponse gains Expired = 5; CorrespondenceNotificationStatusDetailsResponse.Id changes from Guid to Guid?; CorrespondenceNotificationSummaryResponse adds Emails and Smses as IReadOnlyList? and marks the existing Email and Sms properties [Obsolete].
Regression tests and public API snapshot test/.../Features/Correspondence/Models/CorrespondenceResponseTests.cs, test/.../PublicApiTests.PublicApi_ShouldNotChange_Unintentionally.verified.txt	Two new [Fact] tests assert deserialization of V2-shaped notification payloads (null id, plural emails/smses) and of AttachmentsDownloaded in both top-level status and status history. Public API snapshot updated to record all contract changes.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Suggested labels

other

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%.	Write docstrings for the functions missing them to satisfy the coverage threshold.

✅ Passed checks (4 passed)

Check name	Status	Explanation
Linked Issues check	✅ Passed	The pull request successfully addresses the primary coding requirements from issue #17405: adding nullable Id support and Emails/Smses list properties to handle V2 multi-recipient notifications, plus supporting new enum values AttachmentsDownloaded and Expired for proper deserialization.
Out of Scope Changes check	✅ Passed	All code changes are directly aligned with the linked issue objectives: model property updates, enum value additions, test additions for V2 notification deserialization, and public API snapshot updates to reflect the model changes.
Title check	✅ Passed	The title accurately summarizes the main changes: supporting V2 notification details and adding missing enum status values.
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

📝 Generate docstrings

• Create stacked PR
• Commit on current branch

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch fix/correspondence-notification-details-v2-17405

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[coderabbitai]

🧹 Nitpick comments (1)

test/Altinn.App.Core.Tests/Features/Correspondence/Models/CorrespondenceResponseTests.cs (1)

509-523: ⚡ Quick win

Use xUnit asserts in the newly added tests instead of FluentAssertions.

Please replace the new .Should() assertions in these added blocks with xUnit Assert.* equivalents to stay consistent with repo test guidelines.

As per coding guidelines, "**/test/**/*.cs: Prefer xUnit asserts over FluentAssertions in tests".

Also applies to: 564-565

🤖 Prompt for AI Agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In
`@test/Altinn.App.Core.Tests/Features/Correspondence/Models/CorrespondenceResponseTests.cs`
around lines 509 - 523, Replace all FluentAssertions with xUnit Assert
equivalents in the test assertions for statusDetails.Email, statusDetails.Sms,
statusDetails.Emails, and statusDetails.Smses properties. Convert the
.Should().BeNull() calls to Assert.Null(), .Should().Be() calls to
Assert.Equal(), .Should().ContainSingle() calls to Assert.Single(), and
.Should() property access calls to appropriate Assert.NotNull() assertions.
Ensure all assertions in the newly added test blocks (lines 509-523 and also at
lines 564-565 as noted) are converted to use the xUnit Assert.* API for
consistency with repository test guidelines.

Source: Coding guidelines

🤖 Prompt for all review comments with AI agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Nitpick comments:
In
`@test/Altinn.App.Core.Tests/Features/Correspondence/Models/CorrespondenceResponseTests.cs`:
- Around line 509-523: Replace all FluentAssertions with xUnit Assert
equivalents in the test assertions for statusDetails.Email, statusDetails.Sms,
statusDetails.Emails, and statusDetails.Smses properties. Convert the
.Should().BeNull() calls to Assert.Null(), .Should().Be() calls to
Assert.Equal(), .Should().ContainSingle() calls to Assert.Single(), and
.Should() property access calls to appropriate Assert.NotNull() assertions.
Ensure all assertions in the newly added test blocks (lines 509-523 and also at
lines 564-565 as noted) are converted to use the xUnit Assert.* API for
consistency with repository test guidelines.

---

ℹ️ Review info

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 7fbc8434-439e-43cd-a3b8-37fca46ba606

📥 Commits

Reviewing files that changed from the base of the PR and between 79ad1a0 and 7bfcbed.

📒 Files selected for processing (6)

• src/Altinn.App.Core/Features/Correspondence/Models/CorrespondenceStatus.cs
• src/Altinn.App.Core/Features/Correspondence/Models/Response/CorrespondenceAttachmentStatusResponse.cs
• src/Altinn.App.Core/Features/Correspondence/Models/Response/CorrespondenceNotificationStatusDetailsResponse.cs
• src/Altinn.App.Core/Features/Correspondence/Models/Response/CorrespondenceNotificationSummaryResponse.cs
• test/Altinn.App.Core.Tests/Features/Correspondence/Models/CorrespondenceResponseTests.cs
• test/Altinn.App.Core.Tests/PublicApiTests.PublicApi_ShouldNotChange_Unintentionally.verified.txt

[sonarqubecloud]

Quality Gate failed

Failed conditions
B Maintainability Rating on New Code (required ≥ A)

See analysis details on SonarQube Cloud

Catch issues before they fail your Quality Gate with our IDE extension SonarQube for IDE