Repository navigation
[Xamarin.Android.Build.Tasks] remove unused Inputs/Outputs - #2309
Merged
Merged
Conversation
While reviewing our MSBuild targets, I noticed three targets that
declared `Inputs` and `Outputs`, but did not actually update any
files:
- `_CollectConfigFiles`
- `_CollectMdbFiles`
- `_CollectPdbFiles`
This means that MSBuild was unnecessarily looking at files to see if
they exist, and might be comparing timestamps as well. The targets
would also _always_ run, so it doesn't matter to have `Inputs` and
`Outputs` in these targets at all!
I basically removed these `Inputs` and `Outputs`, and saw a
performance gain with just doing that. I also saw performance gains to
targets that depend on these three targets. Since `Inputs` and
`Outputs` timing is internal to MSBuild, I am not sure where the
actual time is being tallied here.
Before:
1 ms _CopyConfigFiles 1 calls
3 ms _CopyMdbFiles 2 calls
3 ms _CollectMdbFiles 1 calls
4 ms _CopyPdbFiles 1 calls
5 ms _CollectPdbFiles 1 calls
5 ms _CollectConfigFiles 1 calls
20 ms _ConvertPdbFiles 1 calls
A total of ~46ms
After:
0 ms _ConvertPdbFiles 1 calls
0 ms _CopyPdbFiles 1 calls
1 ms _CollectMdbFiles 1 calls
1 ms _CopyMdbFiles 2 calls
1 ms _CopyConfigFiles 1 calls
2 ms _CollectConfigFiles 1 calls
5 ms _CollectPdbFiles 1 calls
A total of ~10ms
An overall improvement of ~36ms.
This was the `samples/HelloWorld` project in this repo, a build with
no changes. I suspect the improvement would be even better for larger
projects.
Member
Author
|
Build logs for this change: logs.zip |
dellis1972
approved these changes
Oct 17, 2018
Contributor
|
@jonathanpeppers looks like I was a bit overzealous with the Inputs and Outputs then :) This looks good. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While reviewing our MSBuild targets, I noticed three targets that
declared
InputsandOutputs, but did not actually update anyfiles:
_CollectConfigFiles_CollectMdbFiles_CollectPdbFilesThis means that MSBuild was unnecessarily looking at files to see if
they exist, and might be comparing timestamps as well. The targets
would also always run, so it doesn't matter to have
InputsandOutputsin these targets at all!I basically removed these
InputsandOutputs, and saw aperformance gain with just doing that. I also saw performance gains to
targets that depend on these three targets. Since
InputsandOutputstiming is internal to MSBuild, I am not sure where theactual time is being tallied here.
A total of ~46ms
A total of ~10ms
An overall improvement of ~36ms.
This was the
samples/HelloWorldproject in this repo, a build withno changes. I suspect the improvement would be even better for larger
projects.