Skip to content

fix Korean(and Chinese, Japanese) IME behavior (#4541) - #5615

Merged
Alexandru Dima (alexdima) merged 1 commit into
microsoft:masterfrom
ioklo:topic/ime-fix
May 4, 2016
Merged

Alexandru Dima (alexdima) merged 1 commit into
microsoft:masterfrom
ioklo:topic/ime-fix

Conversation

@ioklo

Copy link
Copy Markdown
Contributor

Hello, this PR is for issue #4541 - Korean characters problem

  • fix displaying Korean letters twice during composition
  • show composition letters between the text not over the text

Doing so, I added ICompositionEvent that has 'data' field. On 'compositionupdate' events, textarea is changed by composition data.

To show composition letters between the text, the visibleRange is calculated every compositionupdate event with composition word. It can be expensive.

I changed the variable shouldEmptyTextArea to be always true because I think textarea should be empty when composition starts but I didn't test with other browsers (How?).

Symptom (VSCode v1.0, type 'dkssudgktpdy')
animation1

Expected (there are two cursors.. it must be fix either)
animation2

And When I composite letters between the text, the letters are displayed over the text. But Korean IME doesn't act like that. (type 'gksrmf')
animation3

Expected
animation4

It is confused that Japanese IME usually show composition letters over the text (in the notepad) but when I tested with Microsoft Word, the composition letters are occupied between the text. (type 'sensei')
animation5

After change
animation6

But It's same as Microsoft Word
animation7

  - fix displaying Korean letters twice during composition
  - show composition letters between the text not over the text
@mention-bot

Copy link
Copy Markdown

By analyzing the blame information on this pull request, we identified alexandrudima, Erich Gamma (@egamma) and João Moreno (@joaomoreno) to be potential reviewers

@alexdima Alexandru Dima (alexdima) added this to the May 2016 milestone Apr 26, 2016
@alexdima
Alexandru Dima (alexdima) merged commit 5939b5c into microsoft:master May 4, 2016
Alexandru Dima (alexdima) added a commit that referenced this pull request May 4, 2016
fix Korean(and Chinese, Japanese) IME behavior (#4541)
@alexdima

Copy link
Copy Markdown
Member

Thank you very much for this change! ❤️

Based on a few issues and on this description I was able to put together an IME Smoke test that we will go through from now on any time we make changes in the input handling and your changes make VSCode work like Word in these test cases!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants