Skip to content
This repository was archived by the owner on Apr 15, 2019. It is now read-only.

Fix incorrectly triggered error toast in voting - Closes #911 - #915

Merged
ginacontrino merged 1 commit into
1.2.1from
911-vote-limit-error-toast
Oct 25, 2017
Merged

Fix incorrectly triggered error toast in voting - Closes #911#915
ginacontrino merged 1 commit into
1.2.1from
911-vote-limit-error-toast

Conversation

@ginacontrino

@ginacontrino ginacontrino commented Oct 25, 2017

Copy link
Copy Markdown
Contributor

What's the problem?
The error toast was displayed despite being within vote limit
#911

What did you do?

  • Moved existing working logic from votingBar into util to reuse in both places

How can I test it?

  • Having already voted for 100 delegates, remove one existing vote and add 2 more (so your total votes are 101/101)
  • There should be no error Toast anynmore
  • Adding one more vote should show error toast

@ginacontrino ginacontrino self-assigned this Oct 25, 2017
@ginacontrino
ginacontrino requested a review from slaweet October 25, 2017 09:59
@ginacontrino
ginacontrino changed the base branch from development to 1.2.1 October 25, 2017 10:00
slaweet
slaweet approved these changes Oct 25, 2017
View reviewed changes

@slaweet slaweet left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job Gina

@ginacontrino
ginacontrino merged commit e11bd70 into 1.2.1 Oct 25, 2017
@ginacontrino
ginacontrino deleted the 911-vote-limit-error-toast branch October 25, 2017 10:32
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer
@slaweet slaweet slaweet approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

@ginacontrino ginacontrino

Labels

✅ ready

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@ginacontrino @slaweet